Fix: rootCoverageReport ignores androidTests coverage results when executeAndroidTests is false #104
Conversation
|
@k4k7us23 thanks for your pull-request, unfortunately I don't have time to look into this right now, I will have a closer look later this week. |
|
@k4k7us23 So it took me a while to take a look at this. Thanks for your contribution, in general I think the changes look good. However I did make some additional changes and removed the direct dependency between the I also made some additional changes to the integration test so that test cases where this plugin should not execute test tasks are a bit more realistic. |
Rolf-Smit
force-pushed
the
fix/gradle_managed_devices_manual_execution
branch
from
e2dfe6b to
6709ae7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
============================================
+ Coverage 80.10% 80.88% +0.78%
- Complexity 46 47 +1
============================================
Files 8 8
Lines 196 204 +8
Branches 30 30
============================================
+ Hits 157 165 +8
Misses 11 11
Partials 28 28 ☔ View full report in Codecov by Sentry. |
…rt tasks These tasks should not depend on each other as they do not depend on each others output, if some direct dependency is needed, it will be on the test tasks.
Rolf-Smit
force-pushed
the
fix/gradle_managed_devices_manual_execution
branch
from
6709ae7 to
0adaaed
Compare
- Fixed: Code coverage data not picked up when using Gradle Managed Devices in combination with flavors (#102) - Fixed: Code coverage data not picked up when using Gradle Managed Devices in combination with executeAndroidTests=false (#104) - Based on Android Gradle Plugin 8.6 API - Compatible with Gradle version 8.7+
- Fixed: Code coverage data not picked up when using Gradle Managed Devices in combination with flavors (#102) - Fixed: Code coverage data not picked up when using Gradle Managed Devices in combination with executeAndroidTests=false (thanks to @k4k7us23) (#104) - Based on Android Gradle Plugin 8.6 API - Compatible with Gradle version 8.7+
2 participants
Problem
In our project we are using gradle managed devices to execute ui tests. Ui tests launch configuration is a bit complicated in our use case, so I had to launch ui tests separately from
Android-Root-Coverage-Plugin. And then after ui tests have finished it's execution, I am using:rootCoverageReport"The problem here, is that coverage results from ui tests are being ignored by:rootCoverageReport. This happens only with gradle managed devices, if I manually execute ui tests on connected emulator, and than use:rootCoverageReportto create aggregated coverage report, everything works as expected.I have created new configuration
gradle-managed-device-dont-execute-android-tests.yamlforIntegrationTest.kt, that reproduces the issue above.Solution
This pull request also contains fix of that problem. Here are key components of the fix:
includeGradleManagedDevicesResults = false, in case ofexecuteAndroidTestsis false. Now that is fixed.project.tasks.findByPath("$path:allDevices${name}AndroidTest")tosubProject.tasks.configureEachinsideJacocoReport.addSubProjectVariant.project.tasks.findByPathwas always returing null, because task$path:allDevices${name}AndroidTestwasn't configured yet at the timeproject.tasks.findByPathis called.